[Infra UI] Disable Infrastructure and Metrics alerts in Serverless #167978

mykolaharmash · 2023-10-04T11:47:33Z

Closes #164683

Summary

This PR disables the infrastructure, metrics and logs alerts rule in Serverless:

Deletes the code responsible for the "Metric Anomaly" rule as it was previously disabled with plans to re-enable it as the previous PR describes but that never happened.
Adds feature flags for all three types of alert rules
Prevents rules registration in serverless based on the feature flags
Adds logic for showing/hiding items in the "Alerts and rules" dropdown
Disables custom threshold rule in the Infra UI by default in serverless as the rule needs to first be enabled by default by @elastic/actionable-observability team (context)

Dropdown

Host details

How to test

Checkout locally Run in Serveless mode
Enable, Infra plugin, custom threshold in Infra, and custom threshold rule in general:

xpack.infra.enabled: true
xpack.infra.featureFlags.customThresholdAlertsEnabled: true
xpack.observability.unsafe.thresholdRule.enabled: true

Go to /app/metrics/hosts and make sure there are no "Infrastructure" and "Metrics" items in the "Alerts and rules" dropdown
Click on "Manage rules" in the "Alerts and rules" dropdown, then "Create rule" to open the rule selection flyout
Make sure there are no rules for "Inventory", "Metrics" or "Logs" threshold
Run Kibana in traditional mode
Make sure the "Alerts and rules" dropdown looks as usual and you can create "Infrastructure" and "Metrics" alerts

apmmachine · 2023-10-04T11:47:50Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
/oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine · 2023-10-05T13:24:52Z

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

mykolaharmash · 2023-10-06T10:35:03Z

@elasticmachine merge upstream

kc13greiner

LGTM!

…a-alerts-serverless

jennypavlova

Good job 💯
It works as expected - the only thing we discussed and I am adding here as well for visibility:
The xpack.observability.unsafe.thresholdRule.enabled: true setting is needed when the infra plugin is enabled in order to make this work.

jennypavlova · 2023-10-09T12:42:59Z

x-pack/plugins/infra/public/alerting/common/components/metrics_alert_dropdown.tsx

-  EuiPopover,
-  EuiHeaderLink,
-  EuiContextMenu,
+import { EuiPopover, EuiHeaderLink, EuiContextMenu } from '@elastic/eui';


Nit: We can merge eui imports:

Suggested change

import { EuiPopover, EuiHeaderLink, EuiContextMenu } from '@elastic/eui';

import {

type EuiContextMenuPanelDescriptor,

type EuiContextMenuPanelItemDescriptor,

EuiPopover,

EuiHeaderLink,

EuiContextMenu,

} from '@elastic/eui';

nice catch, thank you!

kibana-ci · 2023-10-09T14:16:02Z

💚 Build Succeeded

Buildkite Build
Commit: 94b41b4

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`infra`	1.9MB	1.9MB	+604.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`infra`	105.9KB	105.8KB	-34.0B
`observability`	101.3KB	101.3KB	-34.0B
total			-68.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`infra`	49	45	-4

References to deprecated APIs

id	before	after	diff
`infra`	50	49	-1

Total ESLint disabled count

id	before	after	diff
`infra`	58	54	-4

History

💛 Build #165864 was flaky 14beed9
💔 Build #165826 failed f11efeb
💔 Build #165811 failed bbeb9a05c2ff9d03c0734e304d94735824d7a5da
💔 Build #165632 failed 4e295336827c5225b75690457a0db77824655865
💔 Build #165604 failed 600f3f7f1874e83645ba5806ee7dbf8702c007b9
💔 Build #165591 failed 03eb5015b9803618e31cff17ada8c3d371229e86

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

mykolaharmash · 2023-10-10T11:30:01Z

Good job 💯
It works as expected - the only thing we discussed and I am adding here as well for visibility:
The xpack.observability.unsafe.thresholdRule.enabled: true setting is needed when the infra plugin is enabled in order to make this work.

Thank you for the review @jennypavlova! About the setting issue, I talked to the actionable observability team and @roshan-elastic, for now we've decided to put the whole "Alerts and rules" dropdown behind another feature flag (issue with more context) and wait until Custom Threshold rule is generally available in serverless. But this does not prevent us from merging this PR as now the custom threshold in Infra is hidden by default.

maryam-saeidi

AO changes LGTM

maryam-saeidi · 2023-10-11T16:16:08Z

x-pack/plugins/observability/common/custom_threshold_rule/types.ts

@@ -166,7 +166,6 @@ export enum MetricsExplorerChartType {
 export enum InfraRuleType {


I don't know why we have this type in observability plugin, we should clean this up. (We should check it at #159340)

pmuellr

LGTM

Closes #166749 ## Summary This PR adds serverless functional tests for the infra plugin. The main goal is to make sure that the app loads all the pages and successfully navigates between them. As we already have functional tests covering the whole functionality here we want to cover the differences with serverless and some basic checks ensuring that base functionality works correctly. - Update the test to cover disabling the create rule button added [here](#167978): ([x-pack/test_serverless/functional/test_suites/observability/infra/hosts_page.ts](87fb991#diff-76bd05d3fed2c44187682e27b4030ddb9cba1a36235321e0db1b371ef6739cc9)) ⚠️ The tests for the second AC point related to user roles will go in a[ separate issue ](#168931) Test server run: `node scripts/functional_tests_server.js --config=x-pack/test_serverless/functional/test_suites/observability/config.ts` Tests run: `node scripts/functional_test_runner --config=x-pack/test_serverless/functional/test_suites/observability/config.ts --grep "Observability Infra"`

…lastic#167978) Closes elastic#164683 ## Summary This PR disables the infrastructure, metrics and logs alerts rule in Serverless: - Deletes the code responsible for the "Metric Anomaly" rule as it was [previously disabled](elastic#93813) with plans to re-enable it as the previous PR describes but that never happened. - Adds feature flags for all three types of alert rules - Prevents rules registration in serverless based on the feature flags - Adds logic for showing/hiding items in the "Alerts and rules" dropdown - Disables custom threshold rule in the Infra UI by default in serverless as the rule needs to first be enabled by default by @elastic/actionable-observability team ([context](https://elastic.slack.com/archives/C023GDA0WMP/p1696853751040269)) **Dropdown** ![CleanShot 2023-10-05 at 15 22 48@2x](https://github.com/elastic/kibana/assets/793851/fb7344c6-b5ee-4020-bd69-473dcd6be446) **Host details** ![CleanShot 2023-10-05 at 15 23 02@2x](https://github.com/elastic/kibana/assets/793851/8164f82b-323c-4a2a-8cdc-c65a6c0f0c63) ### How to test - Checkout locally Run in Serveless mode - Enable, Infra plugin, custom threshold in Infra, and custom threshold rule in general: ``` xpack.infra.enabled: true xpack.infra.featureFlags.customThresholdAlertsEnabled: true xpack.observability.unsafe.thresholdRule.enabled: true ``` - Go to `/app/metrics/hosts` and make sure there are no "Infrastructure" and "Metrics" items in the "Alerts and rules" dropdown - Click on "Manage rules" in the "Alerts and rules" dropdown, then "Create rule" to open the rule selection flyout - Make sure there are no rules for "Inventory", "Metrics" or "Logs" threshold - Run Kibana in traditional mode - Make sure the "Alerts and rules" dropdown looks as usual and you can create "Infrastructure" and "Metrics" alerts --------- Co-authored-by: Kibana Machine <[email protected]>

Closes elastic#166749 ## Summary This PR adds serverless functional tests for the infra plugin. The main goal is to make sure that the app loads all the pages and successfully navigates between them. As we already have functional tests covering the whole functionality here we want to cover the differences with serverless and some basic checks ensuring that base functionality works correctly. - Update the test to cover disabling the create rule button added [here](elastic#167978): ([x-pack/test_serverless/functional/test_suites/observability/infra/hosts_page.ts](elastic@87fb991#diff-76bd05d3fed2c44187682e27b4030ddb9cba1a36235321e0db1b371ef6739cc9)) ⚠️ The tests for the second AC point related to user roles will go in a[ separate issue ](elastic#168931) Test server run: `node scripts/functional_tests_server.js --config=x-pack/test_serverless/functional/test_suites/observability/config.ts` Tests run: `node scripts/functional_test_runner --config=x-pack/test_serverless/functional/test_suites/observability/config.ts --grep "Observability Infra"`

mykolaharmash force-pushed the 164683-disable-infra-alerts-serverless branch 3 times, most recently from 03eb501 to 600f3f7 Compare October 5, 2023 13:13

mykolaharmash added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.12.0 labels Oct 5, 2023

mykolaharmash marked this pull request as ready for review October 5, 2023 13:24

mykolaharmash requested review from a team as code owners October 5, 2023 13:24

mykolaharmash force-pushed the 164683-disable-infra-alerts-serverless branch from 600f3f7 to 4e29533 Compare October 5, 2023 14:03

kc13greiner self-requested a review October 5, 2023 16:22

mykolaharmash force-pushed the 164683-disable-infra-alerts-serverless branch from 4e29533 to bbeb9a0 Compare October 6, 2023 07:58

mykolaharmash requested a review from a team as a code owner October 6, 2023 07:58

[Infra UI] Disable Infrastructure and Metrics alerts in Serverless

f11efeb

mykolaharmash force-pushed the 164683-disable-infra-alerts-serverless branch from bbeb9a0 to f11efeb Compare October 6, 2023 09:04

Merge branch 'main' into 164683-disable-infra-alerts-serverless

14beed9

kc13greiner approved these changes Oct 6, 2023

View reviewed changes

jennypavlova self-requested a review October 9, 2023 08:27

crespocarlos requested review from crespocarlos and removed request for crespocarlos October 9, 2023 10:20

mykolaharmash added 2 commits October 9, 2023 13:56

Merge remote-tracking branch 'upstream/main' into 164683-disable-infr…

fe0b5ed

…a-alerts-serverless

Rely on logThresholdAlertRuleEnab flag to initialize log alert routs

20e7cea

jennypavlova approved these changes Oct 9, 2023

View reviewed changes

Disable threshold alert rule by default in serverless

94b41b4

maryam-saeidi approved these changes Oct 11, 2023

View reviewed changes

maryam-saeidi mentioned this pull request Oct 11, 2023

[AO] Revisit the Threshold rule's files organization, used types, and variable names #159340

Closed

6 tasks

pmuellr approved these changes Oct 12, 2023

View reviewed changes

mykolaharmash merged commit 3e8058b into elastic:main Oct 12, 2023

jennypavlova mentioned this pull request Oct 12, 2023

[Infra UI] Add infra serverless functional tests #168621

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Infra UI] Disable Infrastructure and Metrics alerts in Serverless #167978

[Infra UI] Disable Infrastructure and Metrics alerts in Serverless #167978

mykolaharmash commented Oct 4, 2023 •

edited

Loading

apmmachine commented Oct 4, 2023

elasticmachine commented Oct 5, 2023

mykolaharmash commented Oct 6, 2023

kc13greiner left a comment

jennypavlova left a comment

jennypavlova Oct 9, 2023

mykolaharmash Oct 10, 2023

kibana-ci commented Oct 9, 2023

ESLint disabled line counts

References to deprecated APIs

Total ESLint disabled count

mykolaharmash commented Oct 10, 2023

maryam-saeidi left a comment

maryam-saeidi Oct 11, 2023

pmuellr left a comment

		@@ -166,7 +166,6 @@ export enum MetricsExplorerChartType {
		export enum InfraRuleType {

[Infra UI] Disable Infrastructure and Metrics alerts in Serverless #167978

[Infra UI] Disable Infrastructure and Metrics alerts in Serverless #167978

Conversation

mykolaharmash commented Oct 4, 2023 • edited Loading

Summary

How to test

apmmachine commented Oct 4, 2023

🤖 GitHub comments

elasticmachine commented Oct 5, 2023

mykolaharmash commented Oct 6, 2023

kc13greiner left a comment

Choose a reason for hiding this comment

jennypavlova left a comment

Choose a reason for hiding this comment

jennypavlova Oct 9, 2023

Choose a reason for hiding this comment

mykolaharmash Oct 10, 2023

Choose a reason for hiding this comment

kibana-ci commented Oct 9, 2023

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

ESLint disabled line counts

References to deprecated APIs

Total ESLint disabled count

History

mykolaharmash commented Oct 10, 2023

maryam-saeidi left a comment

Choose a reason for hiding this comment

maryam-saeidi Oct 11, 2023

Choose a reason for hiding this comment

pmuellr left a comment

Choose a reason for hiding this comment

mykolaharmash commented Oct 4, 2023 •

edited

Loading